Fixes the dark mode display of the payments icon in the settings. - Githubissues

signalapp / Signal-iOS

A private messenger for iOS.

https://signal.org

GNU Affero General Public License v3.0

10.78k stars 3.02k forks source link

Fixes the dark mode display of the payments icon in the settings. #5710

Closed orignaux closed 10 months ago

orignaux commented 10 months ago

First time contributor checklist

[x] I have read the README and CONTRIBUTING documents
[x] I have signed the Contributor Licence Agreement

Contributor checklist

[x] My commits are rebased on the latest main branch
[x] My commits are in nice logical chunks
[x] My contribution is fully baked and is ready to be merged as is
[x] I have tested my contribution on these devices:
- iPhone 15 Pro, iOS 17.0
- iPhone 14 Pro, iOS 17.0

Description

The payment image wasn't set to be rendered as a "Template Image", which caused it to display with incorrect color the dark mode tint was applied.

Before

Screenshot 2023-11-23 at 00 06 16

After

Screenshot 2023-11-23 at 00 17 26

harry-signal commented 10 months ago

thanks for your contribution! We already got a commit to fix this going out in our next release XD just a few days too late!