Can't expand long messages in message Info or View edit history

[odaom]

• [x] I have searched open and closed issues for duplicates
• [x] I am submitting a bug report for existing functionality that does not work as intended
• [x] This isn't a feature request or a discussion topic

---

Bug description

Nothing happens when tapping "Read more" in the Info view and in View edit history. Expected behavior is that the message box expands to show the whole message.

Steps to reproduce

• Open message Info view of a long message that is truncated
• Tap "Read more" at bottom of truncated message

Actual result: Nothing happens.

Expected result: The message expands.

The same is the case for the edit history view, tapping "Read more" does nothing.

Screenshots

Device info

Device: iPhone SE

iOS version: 16.6.1

Signal version: 6.53.0.7

[nishantminerva]

I would like to work on this.

[nishantminerva]

What I found is - That the Message Details screen is not intended to take taps on it. So that's why tapping Read More is not working.

Please let me know if I have to implement the functionality of tap to Read More in Message Details Screen.

[lukasvrenner]

Perhaps, it would be easier if it simply expanded it by default?

[odaom]

Perhaps, it would be easier if it simply expanded it by default?

Considering messages can have arbitrary lengths, this does not sound user friendly. The message info page would lose most of its utility if I have to scroll through 1000 words to just see when it was sent/read. So the default truncation is there for good reason.

[odaom]

Expanding in message info view is actually not that important. You can just go to the message in the chat to read the full length. The actual problem, and the reason I’ve reported this bug, is that it’s the same in message edit history.

If the edit happened somewhere after the truncation, it’s currently impossible to see what the edit was, on iOS. Fixing the "Read more" in edit history seems more important than fixing it on the message info view (although fixing both would be great).

[nishantminerva]

Okay.

[nishantminerva]

I need help to understand how signal code works in IOS.

I tried putting breakpoint so navigate to the Read More button - But found that it's a CVLable.

located the - func didTapTruncatedTextMessage(_ itemViewModel: CVItemViewModelImpl) {} and expandTruncatedTextOrPresentLongTextView(itemViewModel), But not able to understand the code, please help.

I did my best to find and locate the button but was not able to understand the codebase, Can anyone of you explain the whole code base to me? @harry-signal @elaine-signal @sashaweiss-signal @jimio-signal @marissa-signal @pete-signal

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale[bot]]

This issue has been closed due to inactivity.