signalapp / Signal-iOS

A private messenger for iOS.
https://signal.org
GNU Affero General Public License v3.0
10.6k stars 2.95k forks source link

Sharing files via other apps will reset 'disappearing messages' time #5730

Open KommX opened 5 months ago

KommX commented 5 months ago

Bug description

If Signal is in the background (and notifications are turned off?), it doesn't notice changes for the 'disappearing messages' time. Sharing a file via a 3rd party app (e.g. GoodNotes or screenshot) will disrespect the 'disappearing messages' time set in the chat and override it with the last setting before sharing the file.

Steps to reproduce

Actual result: In the 'select recipient' screen, you can already see the old 'disappearing messages' value at the end of the row. When sharing the file, Signal will first reset the 'disappearing messages' time to the last value it knew and will then share the file.

Expected result: Consume the 'disappearing messages' change made by the conversation partner before sending the file.

Screenshots

  1. Partner changes the setting to 1 day, screenshot from partner's device: image

  2. I share a file and my device doesn't see the change yet: image

  3. Partner receives file with wrong disappearing time setting, screenshot from partner's device: image

Device info

Device: iPad 9th Gen

iOS version: 17.2

Signal version: 6.54.0.8

Link to debug log

https://debuglogs.org/ios/6.54.0/7706ebed56ecf523cdd6b7716a44e5731c2e210bdee9424b9df968cfa45a9dfc.zip

stale[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

KommX commented 2 months ago

Is there anything more I should provide?