[x] My commits are rebased on the latest main branch
[x] My commits are in nice logical chunks
[x] My contribution is fully baked and is ready to be merged as is
[x] I have tested my contribution on these devices:
iPhone 13 Pro, iOS 17.3
iPhone 12 Simulator, iOS 15.2
PROBLEM:
Upon attempting registration with a seemingly valid phone number format, such as +44 07XX XXXXXX, the server responds with a status code 422. Subsequently, an alert is presented to the user. However, upon acknowledgement of this alert by the user, the registration process stalls at the stage labelled "Verifying +44 07XX XXXXXX" screen. See #5609 for more details.
FIX:
I fixed the issue by introducing a method on the RegistrationPhoneNumberPresenter protocol. This function is invoked when the user taps the ok button on the Invalid Phone Number alert.
TEST:
The following was tested on iPhone 13 Pro (iOS 17.3), iPhone 15 Pro Simulator (iOS 17.0) and iPhone 12 Simulator ( iOS 15.2):
The "Verifying +44 07XX XXXXXX" screen is dismissed and the user lands back on the "Your Phone Number" screen.
The label under the phone number text field (validationWarningLabel) reads "Invalid phone number. Please enter a valid phone number to register" in the ows_accentRed color.
First time contributor checklist
Contributor checklist
[x] My commits are rebased on the latest main branch
[x] My commits are in nice logical chunks
[x] My contribution is fully baked and is ready to be merged as is
[x] I have tested my contribution on these devices:
PROBLEM:
Upon attempting registration with a seemingly valid phone number format, such as +44 07XX XXXXXX, the server responds with a status code 422. Subsequently, an alert is presented to the user. However, upon acknowledgement of this alert by the user, the registration process stalls at the stage labelled "Verifying +44 07XX XXXXXX" screen. See #5609 for more details.
FIX:
I fixed the issue by introducing a method on the
RegistrationPhoneNumberPresenter
protocol. This function is invoked when the user taps the ok button on the Invalid Phone Number alert.TEST:
The following was tested on iPhone 13 Pro (iOS 17.3), iPhone 15 Pro Simulator (iOS 17.0) and iPhone 12 Simulator ( iOS 15.2):
validationWarningLabel
) reads "Invalid phone number. Please enter a valid phone number to register" in theows_accentRed
color.