Fix handling of PNG attachments for editor (addresses #5761)

frederickding commented 4 months ago

First time contributor checklist

[X] I have read the README and CONTRIBUTING documents
[X] I have signed the Contributor Licence Agreement

Contributor checklist

[X] My commits are rebased on the latest main branch
[X] My commits are in nice logical chunks
[X] My contribution is fully baked and is ready to be merged as is
[x] I have tested my contribution on these devices:
- iPhone 15 Pro, iOS 17.3

Description

These changes are meant to address #5761 by ensuring that isAnimatedImage for any PNG attachment is always determined by internal metadata, not whether it's in a list of MIME types, since PNGs can be either animated or not; and also to define the authoritative list of animated UTI types from those that are "definitely" animated after the a97772265d4ea83e92de0f5067c14ff1142caaaf refactor, not those that are "maybe" animated.

stale[bot] commented 1 month ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 1 month ago

This issue has been closed due to inactivity.

signalapp / Signal-iOS