signalapp / Signal-iOS

A private messenger for iOS.
https://signal.org
GNU Affero General Public License v3.0
10.6k stars 2.95k forks source link

Double tap message to show context menu #5772

Open kevinmbeaulieu opened 3 months ago

kevinmbeaulieu commented 3 months ago

First time contributor checklist

Contributor checklist

Description

In the conversation view, long pressing a message presents the context view for that cell, allowing the user to add reactions, reply, delete the message, etc. To match the behavior that iOS users are accustomed to in iMessage, Signal should also allow double-tapping messages to present this menu. This can also be faster, since double-tapping doesn't have the same time delay that long press gestures have.

The code changes implemented all followed the same patterns as the tap and long press gesture recognizers on that view, so even though it's a few hundred lines it's mostly copy-paste from that and just tweaking the relevant parts.

tohrxyz commented 3 months ago

can't comment on the code, but this would be a good feature to have for sure

great work

stale[bot] commented 3 days ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.