signalapp / Signal-iOS

A private messenger for iOS.
https://signal.org
GNU Affero General Public License v3.0
10.59k stars 2.95k forks source link

Prevent video stop in MediaPageViewController when new attachment arrives. #5787

Open alex1704 opened 2 months ago

alex1704 commented 2 months ago

First time contributor checklist

Contributor checklist

Description

When user opens video attachment, MediaPageViewController presents it and play it. If in this moment user receives new attachment - audio or video then video stops playing. Solution is to reload attachment only if it is different then current one.

Steps to reproduce: Assuming that phone1 received video attachment (say 20 seconds long) at some point

  1. on phone1 open mentioned video attachment
  2. on phone2 send to phone1 photo or audio message
  3. video on phone1 stops playing