signalapp / Signal-iOS

A private messenger for iOS.
https://signal.org
GNU Affero General Public License v3.0
10.59k stars 2.95k forks source link

Unable to share iCalendar (.ics) files into Signal share sheet #5793

Open EvanHahn opened 2 months ago

EvanHahn commented 2 months ago

Bug description

I cannot share iCalendar (.ics) files into Signal via the share sheet. I receive an error message.

I don't know how long this has been happening but I do not think it is new.

I can, however, share them within the app. This suggests to me that it is an issue specific to the share sheet.

Steps to reproduce

  1. Open an iCalendar file.
  2. Share it into Signal via the share sheet.

I built a very simple proof-of-concept on the web. Visit this page on your iPhone. Click the link and try to share the event into Signal.

Actual result: An error message appears.

Expected result: I can successfully share the file.

Screenshots

Setup:

Setup 1 Setup 2

Error in Signal:

Error in Signal

Device info

Device: iPhone 11 Pro

iOS version: 17.4.1

Signal version: 7.8.0 (27)

Link to debug log

org.whispersystems.signal.shareextension 2024-04-14--19-04-46-695.log

These seem to be the relevant lines from the log:

2024/04/15 14:01:35:743  ❤️ [Error+ErrorLocalizedDescription.swift:80 userErrorDescriptionImpl]: Presenting error to user without a specific localizedDescription: SignalShareExtension.ShareViewController.ShareViewControllerError.noInputItems
2024/04/15 14:01:35:756  ❤️ [ShareViewController.swift:549 buildAttachmentsAndPresentConversationPicker()]: building attachment failed with error: noInputItems