Change in app message sound label

404Wolf commented 3 months ago

First time contributor checklist

[X ] I have read the README and CONTRIBUTING documents
[x] I have signed the Contributor Licence Agreement

Contributor checklist

[x] My commits are rebased on the latest main branch
[x] My commits are in nice logical chunks
[x] My contribution is fully baked and is ready to be merged as is
[ ] I have tested my contribution on these devices:
- iDevice A, iOS X.Y.Z
- iDevice B, iOS Z.Y

Description

Change the app setting text for disabling in app message sounds to be "In-Chat Message Sounds." This change addresses a bit of inconsistency with the desktop signal app, and more transparently describes the functionality of the setting.

techytobias commented 3 months ago

I think this is a good change since it wasn't immediately obvious to me that the old setting would turn off both the incoming and outgoing message sound while in the app. The outgoing sound was particularly frustrating for me.

stale[bot] commented 2 days ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

signalapp / Signal-iOS