signalapp / Signal-iOS

A private messenger for iOS.
https://signal.org
GNU Affero General Public License v3.0
10.83k stars 3.04k forks source link

Stickers sporadically not loading #5871

Open chengw01 opened 2 months ago

chengw01 commented 2 months ago

Bug description

Starting morning of September 14th (Eastern time) stickers sporadically fail to load with just the reload button which won't resolve the issue. This progressively got worse throughout the day until no stickers will load. It is marginally better on September 15th. There is no rhythm or rhythm on which stickers will work or not, both animated and static stickers appear to have this problem. Both parties are using Signal on iOS devices on 7.28 (328).

The debug logs at the time of receiving the stickers seem to indicate failure to download an attachment (presumably the sticker) due to failure to decrypt with a "Bad hmac" error

2024/09/14 22:10:30:884 💛 [AttachmentDownloadManagerImpl.swift:440 downloadRecord(_:)]: Downloading attachment 2158 2024/09/14 22:10:31:707 ❤️ [Cryptography.swift:597 decryptFile(at:metadata:validateHmacAndDigest:outputBlockSize:output:)]: assertionError: Bad hmac 2024/09/14 22:10:31:708 ❤️ [AttachmentDownloadManagerImpl.swift:556 downloadRecord(_:)]: Failed to validate: OWSAssertionError(description: "Bad hmac") 2024/09/14 22:10:31:708 ❤️ [AttachmentDownloadManagerImpl.swift:330 didFailToDownload(_:isRetryable:)]: Failed download of attachment 2158

Steps to reproduce

Actual result: Stickers fail to load with a button to retry

Expected result: Stickers load and if animated, play correctly

Device info

Device: iPhone 13 Mini iOS version: 17.6.1 Signal version: 7.28

Link to debug log

https://debuglogs.org/ios/7.28.0/57f91b2b4304300aaacedbc80ed517951741d7973849fc527f3e5dc97c4487ba.zip

chengw01 commented 2 months ago

As a test I switched back to my old Android device (presumably changing the hmac key) and there was no issue with the stickers loading, however when I switched back to iOS the issue reoccurred. There also appears to be times where this is not a problem. It was sporadic this morning (15th), no issues in the afternoon, but persistent in the evening. Hope that helps!

mistweave commented 1 month ago

Have this identical issue on iOS 18 on iPhone 14Pro also. Signal version 7.29(341) https://debuglogs.org/ios/7.29.0/881c054a8b98a5869848388d83cb2638f04a3fedc2ea4fa8bf25e8f09e9561bc.zip

samleehk commented 1 month ago

same issue happened to my IOS 18 Iphone 14pro https://debuglogs.org/ios/7.29.0/7011ffffbf411ab208187a1fc855e3c9e1e004fc8e9a6f2e470cc93fe87e5f2c.zip

ayubun commented 1 month ago

crossposting my sentiment from android issue: https://github.com/signalapp/Signal-Android/issues/13699#issuecomment-2392711464

https://debuglogs.org/ios/7.29.0/5396035c5828ce1b09fc2566b9e574a5eda20c39a4d030b1a9118f679c90807e.zip

image

maxchui commented 1 month ago

I am experiencing the same issue on iOS and macOS Signal.

iOS version: iOS 18.0.1 iOS Signal version: 7.31 (363)

Logs: https://debuglogs.org/ios/7.31.0/b86a8474c363f6356e8217497df2a34324d965877e2b0e36711721ba725d4519.zip