Replace recursive call with while loop to prevent stack overflow. - Githubissues

signalapp / Signal-iOS

A private messenger for iOS.

https://signal.org

GNU Affero General Public License v3.0

10.84k stars 3.04k forks source link

Replace recursive call with while loop to prevent stack overflow. #5884

Open VasilErema opened 1 month ago

VasilErema commented 1 month ago

First time contributor checklist

[x] I have read the README and CONTRIBUTING documents
[x] I have signed the Contributor Licence Agreement

Contributor checklist

[x] My commits are rebased on the latest main branch
[x] My commits are in nice logical chunks
[x] My contribution is fully baked and is ready to be merged as is
[x] I have tested my contribution on these devices:
- Simulator iPhone 16 PRO , iOS 18.0

Description

Recursive call might cause stack overflow if called to many times.
Improvement: replace recursive call with while loop, that won't be affected by the issue.

P.S. I had no stack overflow with old/new code when tested - there was no recursive calls. I picked it as a small first contribution.