signalapp / Signal-iOS

A private messenger for iOS.
https://signal.org
GNU Affero General Public License v3.0
10.85k stars 3.05k forks source link

WebM support #902

Closed rmueller83 closed 1 year ago

rmueller83 commented 9 years ago

As the new TextSecure Android 2.27.0 beta supports larger attachments now, I tried to send some .webm videos to my iPhone. There I only get a "Received unsupported attachment type." message. Here is a sample file: https://webm.html5.org/test.webm Safari also does not seem to open the file, but in WhatsApp it works.

mikeokner commented 9 years ago

Right now the supported attachment types are in this file:

https://github.com/WhisperSystems/Signal-iOS/blob/master/Signal/src/util/MIMETypeUtil.m

I'll look into support for webm when I update my pull request for gifs ( #886 )

dud1337 commented 4 years ago

Any updates here? Quite a common file format.

jumper444 commented 4 years ago

I'm trying to send a small (8 meg!) *.webm audio file to contacts using windows signal desktop (v1.32.1). Clicking "+" attach and selecting the file from disk causes a file attachment placeholder to appear above (to left) of the message box (like images appear), but then it immediately is cleared and goes away.

This issue has nothing to do with file size. Is this thread and my resulting program behavior indicating I can't send a simple audio file to recipients?? (to download then play using another application...I'm NOT asking for some sort of built-in player or functionality..just file delivery).

I thought signal let me send whatever I want to people (within size limits). Is there actually a small filter list??? I can't just send anything I want?

(NOTE: that the post above from Nov 2015 which says "supported attachment types" is 404 Not found...so that is unable to answer the question and I've searched issues)

Explanations for what is happening here? Thanks.

jumper444 commented 4 years ago

(note: if there is some sort of approved list of what the program will and won't allow it would be much more user friendly if a small dialog popped up and said something (instead of just wiping the file away and going back to message entry with no info).

I tried an attach multiple times, then started searching, etc. Unnecessary 'user smashing into a wall' UI situation. Instead (if true) what about a dialog saying "Permitted file size must be <100MB. Permitted file types are .png, .jpg, etc, etc..")

XNinety9 commented 3 years ago

Hi! Digging out this issue as WebM becomes more and more popular each day. Any support planned?

q2apro commented 3 years ago

Recent state is:

  1. Choose a webm video file
  2. Shows up in your own phone (Android) as playable
  3. Receiving users text back (iOS) "I cannot open the file"

Android works! 👍

It would be epic if Signal could play the webm file on iOS too. Thanks.

slingr-dev commented 3 years ago

This issue/feature request needs a much higher priority in my humble opinion.

It breaks the user experience for iOS users who have migrated group chats from WhatsApp, only to have incoming content from Android phones fail to render at all (WEBM).

stale[bot] commented 2 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

dud1337 commented 2 years ago

The bot should not have moved this to won't fix.

NiklasBr commented 2 years ago

Can this bot be blocked/reported somehow? This is still relevant

slingr-dev commented 2 years ago

between failure to action this over 7 years combined with zero CarPlay support (not even notification there is an unread message or anything) I may be forced to crawl back to WhatsApp. This isn't a threat or anything, its that there are standardized features this app is missing and the developers don't even acknowledge it. I've donated a couple times because I know this app is free, but I'm not sure what else I can do to help this along. If anyone has suggestions please let me know.

stale[bot] commented 2 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

slingr-dev commented 2 years ago

this stale bot is an utter POS. yes, this is this relevant. what is blocking it? devs refuse to actually do anything about it.

stale[bot] commented 2 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

NiklasBr commented 2 years ago

what is blocking it? devs refuse to actually do anything about it.

This.

XNinety9 commented 2 years ago

Can devs team fix this once for a while, please?

jumper444 commented 2 years ago

This is of similar issue: more and more websites are using AVIF images. So lately (increasingly) I right click and 'copy image' then go to paste/share it into Signal yet signal doesn't recognize it as an image type. Instead it just displays a download placeholder 'page' with "AVIF" in it. (This means that that neither the sender nor recipient see the image...you have to instead treat it like a spreadsheet or other 'app needed' document...aka...download/save it, then open it with another program like an image viewer.)

Signal is years behind the curve on what is considered 'modern' and 'in common use' for audio, video, and image formats. Yes, these were esoteric and experimental years ago, but they are now native and built into all browsers as well as phones.

jumper444 commented 2 years ago

I haven't checked Signal with Jpeg XL either. That format was fixed and is now moving into common usage as well.

I'm not familiar with Signals internal design. I presume the team didn't code their own implementations of all these formats. Isn't there just a widespread open source AV library that is being used (or COULD be used???) that would easily keep up with evolving formats? Imagemagick? something like that?

For security Signal could disable MOST of the AV library permitted formats (we don't need 100 of them), but then just enable the 5 or 10 that are needed and then the library (and those other developers) keep us up to date?

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

NiklasBr commented 2 years ago

Stale bot, you should ask the devs to answer this, they need to do something.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

NiklasBr commented 1 year ago

I wish the bot would stop spamming.

stale[bot] commented 1 year ago

This issue has been closed due to inactivity.

mggevaer commented 1 year ago

bump

midibyte commented 1 year ago

This is still an issue.

spitemim commented 1 year ago

Why is this not a feature yet? This kills the app.

mggevaer commented 1 year ago

It looks like IOS doesn't support webm video playback directly, I can see why the Signal team is hesitant to implement it if it's not even supported by IOS itself. But it is possible, a number of third party apps support it on IOS, such as VLC media player.

NiklasBr commented 1 year ago

The third party code for webp is already imported via CocoaPods here:

https://github.com/signalapp/Signal-iOS/blob/a81cb65e5b7906ae392249cac9d5c6fffe4096ba/Podfile#L52

jumper444 commented 1 year ago

It looks like IOS doesn't support webm video playback directly, I can see why the Signal team is hesitant to implement it if it's not even supported by IOS itself.

Can I suggest (if Signal team is using this as a reason) that they allow senders and receivers to handle their OWN concerns about whatever AV files they want to send to each other (and what THEY want to do with them) instead of hand-holding or acting like somebody's parent? (no offense) Webp and webm are not insignificant formats and I personally don't care what Apple thinks or wants to support or 'allow'. They can run their own little walled garden or disneyland park as they see fit. The rest of us have actual files and formats and need to get things done in life. (I would also point out that webm/webp are from Google and so we can also expect ulterior motives here.)

The third party code for webp is already imported via here

I can't interpret this statement. Are you replying somehow to say that Signal now has webm/webp/etc support?

NiklasBr commented 1 year ago

Signal has third-party code for webp (unclear if webm is included). My post should be read as a response to the question whether or not Signal is comfortable with including third-part image formats, which I showed they are.

gredin commented 1 year ago

Still relevant. This should be reopened.

jm355 commented 9 months ago

Yeah I sent a video to my friend and they can't see it, apparently cause it's webm and signal doesn't support it on ios for some reason