ed_y not being used in curve25519_keygen

signalapp / curve25519-java

Pure Java and JNI backed Curve25519 implementation.

GNU General Public License v3.0

233 stars 95 forks source link

ed_y not being used in curve25519_keygen #6

Closed kushti closed 8 years ago

kushti commented 9 years ago

In curve_sigs.curve25519_keygen variable ed_y is never used. Seems like a red flag to me. Please re-check the method code against a reference implementation.

benjiqq commented 8 years ago

refers to this line https://github.com/WhisperSystems/curve25519-java/blob/master/common/src/main/java/org/whispersystems/curve25519/java/curve_sigs.java#L9

benjiqq commented 8 years ago

fixed here https://github.com/WhisperSystems/curve25519-java/pull/8