search

signalapp / libsignal-protocol-c

GNU General Public License v3.0
1.41k stars 295 forks source link

Fix warnings #105

Closed christophhagen closed 6 years ago

christophhagen commented 6 years ago

Some fixes to suppress warnings in lib signal-protocol-c code. Mostly casts to smaller types.

dkonigsberg commented 6 years ago

I hate to ask this again, but could you please split out the protobuf-c fixes? That's also "external" code, that's been frozen-in-time and slightly modified to make it build on a certain C89 compiler. I'd like to keep changes to it separated, and should probably consider stepping up to a more recent version of protobuf-c if I find that compatibility with that compiler is no longer necessary.

christophhagen commented 6 years ago

Okay, I removed the protobuf fixes.