search

signalapp / libsignal-protocol-c

GNU General Public License v3.0
1.41k stars 295 forks source link

Using semver and bump 2.3.2 to 3.0.0 according to it #112

Closed darix closed 5 years ago

darix commented 6 years ago

2.3.2 introduced a breaking API change which is not a nice thing. semver would suggest that in this case the major version number should be bumped.

dkonigsberg commented 5 years ago

Will be kept in mind for future library changes.

ghost commented 5 years ago

For packaging, the soname of the library is important and the soname is typically taken from the major number. To get libsignal-protocol-c 2.3.2 into Debian, we need to bump the soname from 2 to 3,

@dkonigsberg Would you make the next major version bump directly from 2 to 4, so that Debian can use 3 for 2.3.2?

If not, we have other options to solve the problem, but this would be the most "clean" approach. Thank you!

(I'm the Debian packager of libsignal-protocol-c, dino-im, and profanity. Furthermore, psi-plus is affected and I'm in contact with its packager.)

tehnick commented 5 years ago

@32d42eee-2809-41ba-9876-72c2844fcb15 See my detailed reply in mailing list: https://alioth-lists.debian.net/pipermail/pkg-xmpp-devel/2019-May/003254.html