search

signalapp / libsignal-protocol-c

GNU General Public License v3.0
1.41k stars 295 forks source link

Consistency ? #115

Open ghost opened 5 years ago

ghost commented 5 years ago

https://github.com/signalapp/libsignal-protocol-c/blob/4a137eaf4eb4421949e2e1dde9f11ec7bc07b88f/src/signal_protocol.h#L503

Almost every field name end with _func, but not here.

dkonigsberg commented 5 years ago

While I agree that there should be more consistency with callback naming conventions, its not immediately obvious which way to go. A few of the callbacks to use the _func suffix, but many do not. So its not a case of making one small change, but rather a case for making a rather large number of small changes. (Note that pull request #116 changes a lot of callback names.)

If someone can point me to a good example of a C style-guide/convention for this, I'll take a change into consideration.

Also, it should be kept in mind that a change like this will break all existing code that uses the library. Therefore, I shouldn't forget to make a larger version number bump when releasing any code that includes such a change.