It also removes the trailing path component /signal for the -I option in libsignal-protocol-c.pc.in, as this leads to "namespace pollution" in the sense that every pkg-config user of this library cannot use the file names of any header file libsignal-protocol-c provides (which are quite many). Leaving the path prefixed by signal/ on the client side is cleaner (and also what other libraries' pkg-config file exports, e.g., OpenSSL has its headers in include/openssl/ but does not include the suffix in its -I option).
Hi,
when linking using the
pkg-configfile,-lmis missing. As far as I can see it is used only once: https://github.com/signalapp/libsignal-protocol-c/blob/71954c53860b83e358c9d8c4898d003f16ace375/src/hkdf.c#L109 This patch adds-lmto thepkg-configfile.It also removes the trailing path component
/signalfor the-Ioption inlibsignal-protocol-c.pc.in, as this leads to "namespace pollution" in the sense that everypkg-configuser of this library cannot use the file names of any header filelibsignal-protocol-cprovides (which are quite many). Leaving the path prefixed bysignal/on the client side is cleaner (and also what other libraries'pkg-configfile exports, e.g., OpenSSL has its headers ininclude/openssl/but does not include the suffix in its-Ioption).Thanks for your consideration.