Remove key exchange session builder code

signalapp / libsignal-protocol-c

GNU General Public License v3.0

1.41k stars 295 forks source link

Remove key exchange session builder code #40

Closed mmdriley closed 7 years ago

mmdriley commented 8 years ago

e.g. session_builder_process_initiate, session_builder_process_response

This was removed from libsignal-protocol-java in August 2016: https://github.com/WhisperSystems/libsignal-protocol-java/commit/f92517c82a92e79ade3551133f7d9a3f721ac8bc

gkdr commented 8 years ago

What is the reasoning behind this? That Signal doesn't use the synchronous key exchange? I think it would be nice to have a maintained reference implementation of the double ratchet which is not asynchronous per se.

mmdriley commented 8 years ago

Since Signal doesn't use this, I don't think "maintained" was really an option. This code is either unmaintained or removed.

gkdr commented 8 years ago

Well, the Signal protocol doesn't have to be only what the Signal app uses, I thought. I see this was done in d83a61a328d4e36bcccf9066c925b63bb75bf968 without further comment here. Too bad, I was actually using that code.