search

signalapp / libsignal-protocol-c

GNU General Public License v3.0
1.41k stars 296 forks source link

Link with math library #58

Closed jubalh closed 7 years ago

jubalh commented 7 years ago

This patch explicitly links signal-protocol-c with the Math library. hkdf_expand() in src/hkdf.c:109 makes use of 'ceil'.

On some systems without explicitly stating the math library it will not build.

Solves https://github.com/WhisperSystems/libsignal-protocol-c/issues/57

dkonigsberg commented 7 years ago

Resolved by 976aaee7fc480040e3b8b148b2e438ff610aa303

jubalh commented 7 years ago

Awesome if one makes the trouble, evining signing contributors agreement, but then doesnt get feedback but just gets his patch overwritten...

jubalh commented 7 years ago

This is quite unfriendly in my opinion