search

signalapp / libsignal-service-java

A Java/Android library for communicating with the Signal messaging service.
GNU General Public License v3.0
587 stars 271 forks source link

License not clear #42

Open michaelforney opened 7 years ago

michaelforney commented 7 years ago

The LICENSE file contains the GPLv3, but README.md says it is licensed under the AGPLv3. These two should be reconciled.

michaelforney commented 7 years ago

This seems like an important thing to clear up.

ghost commented 6 years ago

@moxie0 hello, I'm in the process of packaging this library for Debian GNU/Linux and would be very grateful if you could clarify what seems to be a minor inconsistency. Thanks in advance for this and even more for making Signal Free Software !

five-c-d commented 5 years ago

Still needs fixing. The README.md was updated in 2015 to say AGPLv3, https://github.com/signalapp/libsignal-service-java/commit/e02aea9cfb440b6cf88e6444a4c6bcad2991bc97#diff-04c6e90faac2675aa89e2176d2eec7d8 but the build.gradle and the LICENSE file have always said GPLv3. Logically, because signal4android is definitely GPLv3, since it is a combined work with libsignal-service-java, that means the correct license here is GPLv3. Please change this pair of lines:

To the correct values. My guess would be it should nowadays be saying:

Diff with 3 deletions and 2 insertions:

I can make a PR if that will help

rubdos commented 4 years ago

The README does not seem to be the only issue, some files have an Affero-specific header:

rsmet on nas in libsignal-service-java on  master [📝] via ☕ v1.8.0
❯ rg Affero                                                                                                                                Fri 10 Jul 2020 07:54:01 AM UTC
LICENSE
552:  13. Use with the GNU Affero General Public License.
556:under version 3 of the GNU Affero General Public License into a single
559:but the special requirements of the GNU Affero General Public License,

java/src/main/java/org/whispersystems/signalservice/internal/contacts/entities/DiscoveryResponse.java
5: * it under the terms of the GNU Affero General Public License as published by
12: * GNU Affero General Public License for more details.
14: * You should have received a copy of the GNU Affero General Public License

java/src/main/java/org/whispersystems/signalservice/internal/contacts/entities/RemoteAttestationRequest.java
5: * it under the terms of the GNU Affero General Public License as published by
12: * GNU Affero General Public License for more details.
14: * You should have received a copy of the GNU Affero General Public License

java/src/main/java/org/whispersystems/signalservice/internal/contacts/entities/DiscoveryRequest.java
5: * it under the terms of the GNU Affero General Public License as published by
12: * GNU Affero General Public License for more details.
14: * You should have received a copy of the GNU Affero General Public License

java/src/main/java/org/whispersystems/signalservice/internal/contacts/entities/RemoteAttestationResponse.java
5: * it under the terms of the GNU Affero General Public License as published by
12: * GNU Affero General Public License for more details.
14: * You should have received a copy of the GNU Affero General Public License