signalapp / libsignal

Home to the Signal Protocol as well as other cryptographic primitives which make Signal possible.
GNU Affero General Public License v3.0
3.55k stars 415 forks source link

Fix armv8 feature flag for signal-crypto #343

Closed jrose-signal closed 3 years ago

jrose-signal commented 3 years ago

This was a rebase failure where the armv8 support in signal-crypto dependencies was not actually put behind the armv8 flag. Our CI didn't catch it because we don't do a build that's both stable and targeting aarch64, but for completeness we should get it right.

jrose-signal commented 3 years ago

cc @rubdos

rubdos commented 3 years ago

Oops, was that my rebase failure? I hadn't upgraded Whisperfish yet to the master branch here, which is why I didn't catch it yet...

Patch LGTM, but haven't checked any other Cargo.tomls.