signalapp / libsignal

Home to the Signal Protocol as well as other cryptographic primitives which make Signal possible.
GNU Affero General Public License v3.0
3.55k stars 415 forks source link

Simplify curve25519-dalek dependency #357

Closed jrose-signal closed 3 years ago

jrose-signal commented 3 years ago

Signal has a fork of curve25519-dalek to add some features that are used by zkgroup. However, libsignal-protocol and poksho don't use those features directly, and thus they don't depend on our fork specifically. Anyone outside of Signal using libsignal-protocol can thus use the standard curve25519-dalek and avoid building it twice. Signal will continue using our fork thanks to the workspace patch in the root Cargo.toml.

Additionally, remove all the passthrough features for customizing curve25519-dalek; we don't use any of them, and clients can always specify them directly.