search

signalapp / libsignal

Home to the Signal Protocol as well as other cryptographic primitives which make Signal possible.
GNU Affero General Public License v3.0
3.08k stars 362 forks source link

NPM: publish releases for Linux arm64 #450

Closed dennisameling closed 2 years ago

dennisameling commented 2 years ago

As mentioned in https://github.com/signalapp/libsignal-client/pull/426#issuecomment-1035334639

Linux is a bit of a special case in that we need to explicitly define things like the arm64 linker. Without the cross dependencies, I got linker errors: https://github.com/dennisameling/libsignal-client/runs/5229605777?check_suite_focus=true

Example of a successful build: https://github.com/dennisameling/libsignal-client/actions/runs/1858014293

I've been using this setup in my signal-native-deps repo for a few months: https://github.com/dennisameling/signal-native-deps/blob/75f22a11a11d18b1ed3b85b51d032816579cce00/.github/workflows/build.yaml#L132-L140

jrose-signal commented 2 years ago

Thank you! I'm planning to do a new tag pretty soon, too, so that build will include the arm64 Linux prebuild.