search

signalapp / libsignal

Home to the Signal Protocol as well as other cryptographic primitives which make Signal possible.
GNU Affero General Public License v3.0
3.52k stars 410 forks source link

Change getSender method of SenderCertificate to always return the UUID #492

Closed AsamK closed 1 year ago

AsamK commented 1 year ago

Currently the only user of this method is the ProtcolException constructor, when an UnidentifiedSenderMessageContent is present. All other instances of ProtocolException already use the sender's UUID as sender. So it would be good to have this consistent.

Also brings this in line with similar methods, like getSourceIdentifier on SignalServiceEnvelope in the Android app.

jrose-signal commented 1 year ago

Released in v0.21.1 as ad1fabbbf.