search

signalapp / libsignal

Home to the Signal Protocol as well as other cryptographic primitives which make Signal possible.
GNU Affero General Public License v3.0
3.06k stars 362 forks source link

Update podspec allow other platforms #513

Closed EddieLukeAtmey closed 1 year ago

EddieLukeAtmey commented 1 year ago

resolve #512

jrose-signal commented 1 year ago

Thanks, but there's a little more than just that: you can see in the build settings section that we have to do a manual translation to Rust target names based on the platform and architecture. There are already names for macOS set up, so that should work in theory, but tvOS and watchOS should probably be subsetted out, at least for now.

I'm also realizing that LibSignalClient depends on SignalCoreKit, which doesn't declare support for macOS either, but I think that's mostly just for logging, so maybe that dependency can be moved to a subspec. (EDIT: I missed that you sent a PR to SignalCoreKit as well.)

I suggest testing this locally to make sure it all works, i.e. pod lib lint --platforms=macos should in theory pass once you've built the Rust FFI library.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 1 year ago

This issue has been closed due to inactivity.