signalapp / libsignal

Home to the Signal Protocol as well as other cryptographic primitives which make Signal possible.
GNU Affero General Public License v3.0
3.05k stars 359 forks source link

Exclude unnecessary libraries from apk #548

Closed marinat closed 6 months ago

marinat commented 6 months ago

When I build apk file with signal lib it contains libsignal_jni.dylib and signal_jni.dll, how to exclude them?

jrose-signal commented 6 months ago

Oh, good catch. You can and should add them to your packagingOptions.resources.excludes, as the official Android app does here (they're in that list, you just have to scroll way out, sorry):

https://github.com/signalapp/Signal-Android/blob/e17b07bb12110c0ebeae193cb6fad35d33b57d40/app/build.gradle.kts#L148-L152

I'll leave this issue open to add that to the doc files within libsignal.

jrose-signal commented 6 months ago

Readme updated in v0.38.0 with a mention of the Maven Central artifacts and the exclude options. Thanks for pointing this out!