search

signalapp / libsignal

Home to the Signal Protocol as well as other cryptographic primitives which make Signal possible.
GNU Affero General Public License v3.0
3.62k stars 420 forks source link

Fixed use of a wrong function #568

Closed dtimoshenko99 closed 7 months ago

dtimoshenko99 commented 7 months ago

PreKeyBundle methods preKeyId and signedPreKeyId used the same function call to signal_pre_key_bundle_get_signed_pre_key_id, so they returned same values. Fixed this, so that preKeyId would use signal_pre_key_bundle_get_pre_key_id.

jrose-signal commented 7 months ago

Oh no, thank you! You can see Signal-iOS doesn't actually extract these values after they've built the PreKeyBundle. 😅

dtimoshenko99 commented 7 months ago

Ahh, I see, is it a valid pr anyway then? 😅

jrose-signal commented 7 months ago

Yes, thank you, we'll fix it on our internal release branch. We shouldn't have blatantly incorrect functions exposed in the API even if they're not currently in use. :-)

dtimoshenko99 commented 7 months ago

Thank you!

jrose-signal commented 7 months ago

Fixed in v0.45.0!