search

signalapp / libsignal

Home to the Signal Protocol as well as other cryptographic primitives which make Signal possible.
GNU Affero General Public License v3.0
3.05k stars 359 forks source link

nightly builds fail due to curve25519-dalek #575

Closed saman3d closed 2 weeks ago

saman3d commented 1 month ago

due to this issue Build fails on nightly-2024-02-05 dalek builds started to fail on nightly 2024-02-05.

they released a new patch version fixing this issue. pr: Fix nightly build tag: 4.1.2

please update curve25519-dalek dependency version

saman3d commented 1 month ago

I need to build my project with the new rust nightly version. can I open a pr for this issue?

jrose-signal commented 1 month ago

We're discussing what to do about 4.1.2 not passing its own CI tests on nightly (because new warnings have been introduced). Upstream has fixes for that as well, but they're not in an actual tag yet.

Note that you don't need to use Signal's fork of curve25519-dalek unless you're using zkgroup. The other crates can use the normal upstream version.

jrose-signal commented 1 month ago

(Update: we asked the dalek folks for a new tag, they haven't committed to one yet.)

jrose-signal commented 2 weeks ago

Included in v0.51.1, using curve25519-dalek v4.1.3!