Fix warnings and clippy warnings

signalapp / ringrtc

GNU Affero General Public License v3.0

550 stars 135 forks source link

Fix warnings and clippy warnings #20

Closed MichaelMcDonnell closed 3 years ago

MichaelMcDonnell commented 3 years ago

There were some unnecessary casts that were generating warning. There were also some clippy warnings mostly related to initializing structs in an un-idiomatic way.

jim-signal commented 3 years ago

Hi @MichaelMcDonnell, thanks for the fixes. We already fixed up many of them to work with the latest 1.49 compiler and will post that in a new release soon (probably 2.9.0). If you could rebase on that and let us know if there are any missing items, we could probably merge your PR.

MichaelMcDonnell commented 3 years ago

Ok I will take a look again once you push your changes to master.

jim-signal commented 3 years ago

We cherry-picked your fixes for Android, thanks.

See this commit: https://github.com/signalapp/ringrtc/commit/27749117a3a78811bb4efb90c3250931f3cd8792

MichaelMcDonnell commented 3 years ago

Thanks!