search

signalapp / ringrtc

GNU Affero General Public License v3.0
550 stars 135 forks source link

A note about the recent blog post on expanding group calls #37

Closed ndgunebo closed 2 years ago

ndgunebo commented 2 years ago

Hi @peter-signal,

Great blog post at https://signal.org/blog/how-to-build-encrypted-group-calls! One comment: I noticed some of the GitHub links to lines of code are using the master branches of the repos. This can get out of sync overtime (if more lines are added or removed the line numbers won't match anymore), so I believe it would be best to use a commit hash or a tag.

jrose-signal commented 2 years ago

Thanks for catching this! Fixed all links to refer to current tags.