search

signalapp / ringrtc

GNU Affero General Public License v3.0
550 stars 135 forks source link

deps: fetch build artefacts using a proxy where necessary #52

Closed jnsgruk closed 1 year ago

jnsgruk commented 1 year ago

I've been struggling to build Signal from source where the build machine is behind a proxy.

This change will have no effect during build unless the HTTPS_PROXY variable is set, in which case it establishes an agent that will ensure the https.get calls use the proxy correctly.

I'm open to suggestions on a different approach if the addition of another dependency is too undesirable.

jnsgruk commented 1 year ago

(I have now signed the CLA!)

jnsgruk commented 1 year ago

Updated per your review, thanks! I've done the same over on https://github.com/signalapp/better-sqlite3/pull/12

rashad-signal commented 1 year ago

Thanks for making the changes. It's now available in 9dca1e6f895c8f843ed7f333ad12eea63e543e5c which is part of RingRTC v2.34.4.

jnsgruk commented 1 year ago

Thanks @rashad-signal! Do I need to do anything with the similar pull on better-sqlite3?