search

signalflatpak / signal

Flatpak builds for Signal, from source
https://signalflatpak.github.io/signal/
GNU Affero General Public License v3.0
2 stars 0 forks source link

Remove ringrtc #5

Closed julianfairfax closed 1 month ago

julianfairfax commented 2 months ago

This MR removes the ringrtc code and patches, which shouldn't be needed anymore, and supports testing without being on a tag.

adamthiede commented 1 month ago

What does adding another actions step get us, other than having to upload and download the assets again? Even with that I think installing the flatpak deps is unnecessary in that step, right?

Sorry if I'm missing something, obvious - currently traveling for a family emergency and I'm a bit out of sorts.

julianfairfax commented 1 month ago

What does adding another actions step get us, other than having to upload and download the assets again? Even with that I think installing the flatpak deps is unnecessary in that step, right?

Sorry if I'm missing something, obvious - currently traveling for a family emergency and I'm a bit out of sorts.

It allows us to only upload the new version on a tag, so we can test without deleting current tags.

adamthiede commented 1 month ago

Ok - I still don't see the need for installing a bunch of dependencies in that step though, since it's not building anything, right? Just downloading the builds from actions and uploading them to a release? You may also want to take a look at the way I'm moving the files out here: https://github.com/signalflatpak/signal/blob/master/.github/workflows/build.yml#L135

It appears the files are downloaded to specifiedPath/artifactName/actuallyTheArtifact, not just specifiedPath/artifactName

julianfairfax commented 1 month ago

Ok - I still don't see the need for installing a bunch of dependencies in that step though, since it's not building anything, right? Just downloading the builds from actions and uploading them to a release?

I think you're right about that actually.

julianfairfax commented 1 month ago

It appears the files are downloaded to specifiedPath/artifactName/actuallyTheArtifact, not just specifiedPath/artifactName

I don't really understand this.

adamthiede commented 1 month ago 
      - name: download release artifacts
        uses: actions/download-artifact@v4
        with:
          path: debs
      - name: install deps
        shell: bash
        run: |
          # checking if debs are downloaded
          ls -alh debs/
          mv debs/*/*.deb .

In the above example, I'm downloading the release artifacts to ./debs. The actual .deb file signal-desktop_arm64.deb gets downloaded to ./debs/signal-desktop_arm64.deb/signal-desktop_arm64.deb. The first signal-desktop_arm64.deb is a folder with the same name as the artifact.

I'm not sure why it is that way, but apparently that's how it is. Sorry I did a bad job at explaining it before.

julianfairfax commented 1 month ago 
      - name: download release artifacts
        uses: actions/download-artifact@v4
        with:
          path: debs
      - name: install deps
        shell: bash
        run: |
          # checking if debs are downloaded
          ls -alh debs/
          mv debs/*/*.deb .

In the above example, I'm downloading the release artifacts to ./debs. The actual .deb file signal-desktop_arm64.deb gets downloaded to ./debs/signal-desktop_arm64.deb/signal-desktop_arm64.deb. The first signal-desktop_arm64.deb is a folder with the same name as the artifact.

I'm not sure why it is that way, but apparently that's how it is. Sorry I did a bad job at explaining it before.

I now move them after downloading them.

Edit: was also needed for the checksums, done.