search

signalfx / golib

Golib contains various useful golang libraries
Apache License 2.0
69 stars 18 forks source link

sfxclient/httpsink: use hex encoded string representation for loggabl… #230

Closed jgheewala closed 3 years ago

jgheewala commented 3 years ago

…e headers

if sha1 representation bytes is directly converted to string the output is garbage during logging. Instead use go built-in hex package EncodeToString() api

jgheewala commented 3 years ago

that failure is due to docker box type being small and test cases not able to complete. This is taken care off in separate commit