signalfx / maestro-ng

Orchestration of Docker-based, multi-host environments
https://signalfx.com
Apache License 2.0
683 stars 83 forks source link

add environment vars that look like docker links env vars #140

Open wt opened 9 years ago

wt commented 9 years ago

Would it make sense to add env vars for the service discovery that look like docker links env vars?

https://docs.docker.com/userguide/dockerlinks/#environment-variables

mpetazzoni commented 9 years ago

Maybe, but I'm not sure. I never really understood why Docker puts the port number inside the variable name, making it very difficult to find out what the port number of a dependent service is, unless you use a regexp on the environment variable names?

Also, Maestro supports linking containers together already via Docker links, in which case Docker itself will add the environment variables that you need.

wt commented 9 years ago

Well, one nice thing is the other frameworks seem to be creating compatible env vars inside their containers. It would be nice to get maestro on that train also.