search

signalfx / maestro-ng

Orchestration of Docker-based, multi-host environments
https://signalfx.com
Apache License 2.0
683 stars 83 forks source link

Introduced logdriver (logconfig) support, including tests. #144

Closed jverhoeven closed 9 years ago

jverhoeven commented 9 years ago

Added host_config to support log config. Added all start parameters to host_config as well, since they are deprecated on the container.start() and cause incorrect behavior. Removed the parameters from container start.

mpetazzoni commented 9 years ago

LGTM. Could you squash your commits together?

mpetazzoni commented 9 years ago

By the way make sure your host_config change is compatible with the version of docker-py that is listed in requirements.txt (otherwise it needs to be bumped up to match)

jverhoeven commented 9 years ago

Ok. Squashed it. Ran the tests with docker-py 1.3.0 which the current minimum and checked the release notes. Seems all ok.

mpetazzoni commented 9 years ago

Thanks!