Maestro logs - Githubissues

signalfx / maestro-ng

Orchestration of Docker-based, multi-host environments

https://signalfx.com

Apache License 2.0

683 stars 83 forks source link

Closed lightcode closed 9 years ago

lightcode commented 9 years ago

This pull request modifies two things:

I've done a quick optimization with maestro logs implementation, I use directly the tail argument from the docker-py API.
I've modify maestro logs -F to continue to print logs even if the container is restarted. I do by tracking events in docker and if a container with the same name is started, Maestro will print logs of the new container (even if the container ID changes).

mpetazzoni commented 9 years ago

Looks cool. Just a few comments

lightcode commented 9 years ago

Thanks, I've fixed my pull request.