Open iangkent opened 9 years ago
Related issue: https://github.com/docker/machine/issues/1335
Thanks for reporting this. This seems like something that should be addressed by docker-machine or docker-py though to make sure it's compatible with all setups. As said in docker/docker-py#731, it feels like a security faux-pas to set assert_hostname=False
.
Since docke-py >=1.4.0 is required in https://github.com/signalfx/maestro-ng/blob/master/requirements.txt#L1 and the fix is included in docker-py 1.9.0, so it is safe to close this issue NOW when docker-py 1.9.0 will be installed by defualt.
Thanks. I'll keep this open until I bump the docker-py requirement to >= 1.9.0
, but I need to assess what that entails first.
I am trying to use maestro to orchestrate docker containers running on machine created using docker-machine. I configured ship for TLS as documented by maestro-ng project. http://maestro-ng.readthedocs.org/en/latest/
When I try to start a container via maestro I get the following error:
This seems to be caused by https://github.com/docker/docker-py/issues/731
The workaround is to disable hostname validation in call to docker-py Client API. https://docker-py.readthedocs.org/en/latest/boot2docker/
I put the workaround in maestro module entities.py and it worked. I added this param: assert_hostname=False
to: https://github.com/signalfuse/maestro-ng/blob/master/maestro/entities.py#L130