search

signalfx / maestro-ng

Orchestration of Docker-based, multi-host environments
https://signalfx.com
Apache License 2.0
685 stars 83 forks source link

Add new auditor that gathers hostnames and services for a given maest… #176

Closed aeuio closed 8 years ago

aeuio commented 8 years ago

…ro action, and executes a script with the hostnames and services, realm and maestro action as arguments.

mpetazzoni commented 8 years ago

See my comments. Also, please read http://chris.beams.io/posts/git-commit/ and fix your commit message.

aeuio commented 8 years ago

Will fix up the commit message soon!

mpetazzoni commented 8 years ago

Looks good. Please remove the use of StringIO since you don't need it, then squash your commits together into one, descriptive commit and it should be ready to merge!

aeuio commented 8 years ago

Done and commits squashed - thanks for all the excellent feedback!

mpetazzoni commented 8 years ago

Thanks! Looks great!