search

signalfx / signalfx-go-tracing

BSD 3-Clause "New" or "Revised" License
13 stars 16 forks source link

Tests failure for github.com/Shopify/sarama 1.29.0 #141

Open pellared opened 3 years ago

pellared commented 3 years ago

The instrumentation for https://github.com/Shopify/sarama seems not to work for version greater or equal than 1.29.0 The tests in dependabot bump PR failed: https://github.com/signalfx/signalfx-go-tracing/pull/137

pellared commented 3 years ago

The sarama instrumentation has been rewritten in OTel. See: https://github.com/open-telemetry/opentelemetry-go-contrib/pull/754

Postponing as we might have a GA of https://github.com/signalfx/splunk-otel-go before anyone has any problem with this issue.