search

signalfx / signalfx-go

Go client library and instrumentation bindings for SignalFx
https://www.signalfx.com
Apache License 2.0
14 stars 51 forks source link

Fix PagerDuty Integration query #120

Closed mazzy89 closed 3 years ago

mazzy89 commented 3 years ago

Signed-off-by: Salvatore Mazzarino smazzarino@sessionm.com

Fixing an issue in the URL parsing. ? could not be parsed correctly. This have as result to not found the integration when the client is used for instance in Terraform provider

mazzy89 commented 3 years ago

@keitwb could you please take a look at this?

I have tested with the Terraform provider and now it looks good. Thanks. I'll make sure to wire the change also in the Terraform provider

mazzy89 commented 3 years ago

Thanks @keitwb. I wanted to make it look like the params as for the other cases. But I did not fully look at why the request string was malformed.

mazzy89 commented 3 years ago

@keitwb in order to update the Terraform provider, do you want to wire a release here or I can go and update the go modules there?

mazzy89 commented 3 years ago

A release has been already created. Fabolous.thanks @keitwb