signalfx / signalfx-go

Go client library and instrumentation bindings for SignalFx
https://www.signalfx.com
Apache License 2.0
14 stars 51 forks source link

Don't send empty orderBy query param and correct metrics search results field #127

Closed rmfitzpatrick closed 3 years ago

rmfitzpatrick commented 3 years ago

These changes prevent sending the orderBy query parameter in remaining search helpers if an empty string is provided (currently triggering an issue with the API).

They also correct what appears to be a typo on the RetrieveMetricMetadataResponseModel struct that occurred during the OpenAPI-based helper generation. As far as I can tell this field has never been named "result" in the product. This includes a potential breaking change by updating the Result field name to Results to match the other models and response. I opted for this change to meet the signatures of the other result models and since it's not been functional I'm not sure how breaking it can actually be considered.