signalfx / signalfx-go

Go client library and instrumentation bindings for SignalFx
https://www.signalfx.com
Apache License 2.0
14 stars 51 forks source link

AWS/WAFv2 is missing #139

Closed spurge closed 2 years ago

spurge commented 3 years ago

We need to correlate traffic with metrics from AWS CloudFront, WAFv2, load balancers and service metrics. I tried implement this myself and deploy this with your Terraform provider, but got a 400 as this doesn't seem implemented in your backend.

AWS WAF is legacy and we need support for WAFv2 which has been available since Nov 2019.

https://github.com/spurge/signalfx-go/commit/e0d53c6f2bf05d3c5acef15a0345941eccf6c46d

mmusik commented 3 years ago

hi, a Splunker here. We've added the request to add WAFV2 metrics to our internal backlog; you're right it's not in the list of things supported out of the box. For now, you should be able to workaround that specifying WAFV2 as a custom namespace in the AWS integration (you can add any Cloudwatch namespace you want this way). In the API it looks like this:

{
    ....
    "customNamespaceSyncRules": [
        {
            "namespace": "AWS/WAFV2",
            "filter": null,
            "defaultAction": null
        }
    ],
    ...
}
spurge commented 3 years ago

Thanks @mmusik, I'll try that!

mmusik commented 2 years ago

@spurge AWS/WAFV2 is enabled in our backend and was just added to the list of namespaces here as well https://github.com/signalfx/signalfx-go/pull/140/files

bgola-signalfx commented 2 years ago

Closing as the work is already done via #140