search

signalfx / signalfx-go

Go client library and instrumentation bindings for SignalFx
https://www.signalfx.com
Apache License 2.0
14 stars 48 forks source link

Fix `labelResolutions` in detector model #143

Closed pdecat closed 2 years ago

pdecat commented 2 years ago

This PR fixes the model for the detector endpoint according to official documentation (which matches what I can see in actual API responses): https://dev.splunk.com/observability/reference/api/detectors/latest#endpoint-retrieve-detectors-query

Ideally, all model files should be generated from the OpenAPI document that was supposedly available from https://github.com/signalfx/api-reference, but this repository is nowadays inexistant and I've searched for another source in vain.

pdecat commented 2 years ago

Looks like CI is broken on master following the merge of this PR but for some unrelated reason:

--- FAIL: TestSpanWriter (0.00s)
    --- FAIL: TestSpanWriter/Should_cycle_buffer_without_losing_anything_(inBatchSize:_1) (1.08s)
        span_writer_test.go:42: 
                Error Trace:    span_writer_test.go:42
                                            span_writer_test.go:147
                Error:          
                Test:           TestSpanWriter/Should_cycle_buffer_without_losing_anything_(inBatchSize:_1)
FAIL
FAIL    github.com/signalfx/signalfx-go/writer  16.017s
?       github.com/signalfx/signalfx-go/writer/template [no test files]
FAIL

https://app.circleci.com/pipelines/github/signalfx/signalfx-go/537/workflows/a8645836-31e6-4dae-930c-9b98b312aa1f/jobs/1320

keitwb commented 2 years ago

@pdecat looks like just a flaky test failure.