signalfx / signalfx-go

Go client library and instrumentation bindings for SignalFx
https://www.signalfx.com
Apache License 2.0
14 stars 48 forks source link

Azure/GCP integration: change PollRate type to int64 (see note in the description) #153

Closed bgola-signalfx closed 2 years ago

bgola-signalfx commented 2 years ago

IMPORTANT NOTE: PR #155 improves upon this work and provides a backwards-compatible solution.


Align poll rate handling with Splunk Observability API. As of Mar 2022 the API supports any value between 1 and 10 minutes (in milliseconds).

Previously AWS was restricted to 1-5 mins. Azure and GCP used to support either 1 or 5 minute intervals.

This is a BREAKING CHANGE as the PollRate type was previously used to define poll rate value. Now it's just a regular int64 (value in milliseconds).