signalfx / signalfx-go

Go client library and instrumentation bindings for SignalFx
https://www.signalfx.com
Apache License 2.0
14 stars 51 forks source link

Add AWS/GlobalAccelerator to AWS services list #189

Closed alwin-stripe closed 1 year ago

alwin-stripe commented 1 year ago

Hi there,

I would like to import metrics under the AWS/GlobalAccelerator namespace into SFX.

diff --git a/integration/model_aws_service.go b/integration/model_aws_service.go
index 619f492..56a3c9a 100644
--- a/integration/model_aws_service.go
+++ b/integration/model_aws_service.go
@@ -50,6 +50,7 @@ const (
        AWSFIREHOSE                  AwsService = "AWS/Firehose"
        AWSFSX                       AwsService = "AWS/FSx"
        AWSGAME_LIFT                 AwsService = "AWS/GameLift"
+       AWSGLOBAL_ACCELERATOR        AwsService = "AWS/GlobalAccelerator"
        AWSINSPECTOR                 AwsService = "AWS/Inspector"
        AWSIO_T                      AwsService = "AWS/IoT"
        AWSIO_T_ANALYTICS            AwsService = "AWS/IoTAnalytics"
@@ -142,6 +143,7 @@ var AWSServiceNames = map[string]AwsService{
        "AWS/Firehose":                AWSFIREHOSE,
        "AWS/FSx":                     AWSFSX,
        "AWS/GameLift":                AWSGAME_LIFT,
+       "AWS/GlobalAccelerator":       AWSGLOBAL_ACCELERATOR,
        "AWS/Inspector":               AWSINSPECTOR,
        "AWS/IoT":                     AWSIO_T,
        "AWS/IoTAnalytics":            AWSIO_T_ANALYTICS,

I don't believe I have write permissions on the repo. Can someone please help me make this change on my behalf or grant me permissions to make the change myself?

Thanks, Alwin

alwin-stripe commented 1 year ago

https://github.com/signalfx/signalfx-go/pull/195