signalfx / signalfx-go

Go client library and instrumentation bindings for SignalFx
https://www.signalfx.com
Apache License 2.0
14 stars 51 forks source link

Fix SearchMetricTimeSeries args #197

Closed bodepd closed 1 year ago

bodepd commented 1 year ago

The current arguments to the method don't match what the api expects, which is a start and end timestamp as well as a resolution int.

This patch updates the method so that it takes the correct arguments to pass into the query string.

benkeith-splunk commented 1 year ago

I think this is the wrong endpoint that you are changing here in the client. The endpoint you modified is this one: https://dev.splunk.com/observability/reference/api/metrics_metadata/latest#endpoint-retrieve-metric-timeseries-metadata

Are you trying to do signalflow computations? If so there is a Signalflow client that I am about to do a major upgrade on in #198.