search

signalfx / signalfx-go

Go client library and instrumentation bindings for SignalFx
https://www.signalfx.com
Apache License 2.0
14 stars 51 forks source link

Allow http.Client to be injected #2

Closed keitwb closed 5 years ago

keitwb commented 5 years ago

To use this in the Smart Agent, we would need for several http.Client options to be tuneable. A lot of API clients allow you to either override the http.Client instances used, either by a setter method or just making the http.Client field an exported memory of the client struct so it can be directly set. This would probably be the most flexible approach compared to trying to pass through all of the options that http.Client has on it. The Smart Agent's dimension property updater client uses this option set.

cory-signalfx commented 5 years ago

On it!

cory-signalfx commented 5 years ago

Done in #3