search

signalfx / signalfx-go

Go client library and instrumentation bindings for SignalFx
https://www.signalfx.com
Apache License 2.0
14 stars 51 forks source link

implement ComputationError struct, so applications can index into error metadata #74

Closed rma-stripe closed 4 years ago

rma-stripe commented 4 years ago

Based on the signalfx-python implementation[0][1], which always exposes a code and sometimes exposes a message/error type (if they are available).

[0] https://github.com/signalfx/signalfx-python/blob/cfbda55989bc0e7ff48be82f2510f378d97d30c6/signalfx/signalflow/ws.py#L311-L314 [1] https://github.com/signalfx/signalfx-python/blob/cfbda55989bc0e7ff48be82f2510f378d97d30c6/signalfx/signalflow/errors.py#L28-L35

cory-signalfx commented 4 years ago

Hey @keitwb, thoughts on this?

rma-stripe commented 4 years ago

Thanks @keitwb, I pushed another commit doing exactly that. Are we ok to merge?

cory-signalfx commented 4 years ago

Thanks, @rma-stripe! Tag incoming, but got one other one to sneak in.