signalfx / signalfx-go

Go client library and instrumentation bindings for SignalFx

https://www.signalfx.com

Apache License 2.0

14 stars 48 forks source link

Fix property name test #94

Closed cory-signalfx closed 4 years ago

cory-signalfx commented 4 years ago

Summary

Fixes busted test

Motivation

Missed this test being broken. Can't cast a []interface{} directly without casting each item.

cc @shrivu-stripe

cory-signalfx commented 4 years ago

Hey @shrivu-stripe! I missed this somehow in the testing pass — I didn't realize you had to cast each interface{} in the slice. Good thing CircleCI emails me!

Double check you're are running your local tests with ./... since maybe you never ran this test?

shrivu-stripe commented 4 years ago

Hey @cory-signalfx, sorry just started learning Go. TIL ./..., thanks!

cory-signalfx commented 4 years ago

In that case: well done and congratulations on a great PR. 😄