signalfx / signalfx-go

Go client library and instrumentation bindings for SignalFx
https://www.signalfx.com
Apache License 2.0
14 stars 51 forks source link

signalflow: Handle race on client close #99

Closed keitwb closed 4 years ago

keitwb commented 4 years ago

Messages that came in after the channel closed were casuing a panic by sending to a closed channel. This will ensure no messages are sent to a channel after it is closed on client shutdown.

Fixes #98.

cory-signalfx commented 4 years ago

This seems fine, but flagging for @keitwb that there are some flaky datapoint tests in here.